Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DH-18086: grpc transport #202

Merged
merged 10 commits into from
Jan 21, 2025
Merged

feat: DH-18086: grpc transport #202

merged 10 commits into from
Jan 21, 2025

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jan 9, 2025 •
edited
Loading

DH-18086: Use custom grpc transport. Note that this shouldn't introduce any functional changes. It just enables the http based gRPC transport to be used which will set us up for Envoy support but is also a preferred transport to websockets.

Testing

I've tested the following scenarios:

  • Non-envoy connections should work
  • Community http connections should work
  • Community https connections should work if self-signed certs are properly configured via NODE_EXTRA_CA_CERTS

Confirmed that setting debug: true shows gRPC transport logs

@bmingles bmingles force-pushed the DH-18086_grpc-transport branch 2 times, most recently from e949981 to 1fd064a Compare January 14, 2025 16:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:10:20
 A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2243
should return custom settings: Empty configspassed ✅187
should return custom settings: Populated configspassed ✅136
should be able to load VSCodepassed ✅1046
should only be visible when a supported file type is active: test.groovypassed ✅2921
should only be visible when a supported file type is active: test.pypassed ✅1033
 A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles mentioned this pull request Jan 14, 2025
Merged
@bmingles bmingles force-pushed the DH-18086_grpc-transport branch from b8d6fcb to 0c5ce14 Compare January 16, 2025 17:18
bmingles added a commit to deephaven/web-client-ui that referenced this pull request Jan 16, 2025
@bmingles
feat: DH-18086: gRPC transport implementation for nodejs backed by ht…
3b5c7d3 
…tp2 (#2339)

DH-18086: gRPC transport implementation for nodejs backed by http2

Note that this is not consumed anywhere in the web but will be used by
the vscode extension and tested on
deephaven/vscode-deephaven#202
@bmingles bmingles force-pushed the DH-18086_grpc-transport branch from bc64340 to c8db2fc Compare January 21, 2025 17:19
@bmingles bmingles marked this pull request as ready for review January 21, 2025 17:38
@bmingles bmingles requested a review from mofojed January 21, 2025 17:38
@bmingles bmingles merged commit 48ee7a9 into main Jan 21, 2025
7 checks passed
@bmingles bmingles deleted the DH-18086_grpc-transport branch January 21, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmingles @mofojed